GH-496 GW target own cluster #638

maksymvavilov · 2023-10-25T13:24:10Z

From the original only 1 task is left that are covered here: validate Gateway CR when it arrives for the reconciliation loop and add a test for an invalid Gateway.

In this context invalid == has a mixture single- and multicluster addresses. We expect only one type of addresses to be present at the Gateway CR.

I'm also giving a second life to the traffic.Gateway transforming it into the utils.GatewayWrapper to preform the mentioned check. Keeping it separate from main packages for

Simplicity of policy controllers departure
Possibilities to use the wrapper in other packages without the fear of import cycles

closes #496

pkg/controllers/dnspolicy/dnspolicy_dnsrecords.go

pkg/traffic/gateway.go

pkg/controllers/dnspolicy/dnspolicy_dnsrecords.go

pkg/utils/gateway_wrapper.go

test/policy_integration/dnspolicy_controller_test.go

mikenairn · 2023-11-15T10:03:34Z

Few small comments/suggestions, but i think this is looking good. I'm not sure if utils will be the eventual home of the gateway wrapper but its fine for now, we can decide where it should live as it evolves (Closer alignment/merge with MultiClusterGatewayTarget).

maksymvavilov · 2023-11-16T13:48:07Z

Few small comments/suggestions, but i think this is looking good. I'm not sure if utils will be the eventual home of the gateway wrapper but its fine for now, we can decide where it should live as it evolves (Closer alignment/merge with MultiClusterGatewayTarget).

Would you have a better place/name in mind for the GatewayWrapper package? 🤔 don't like either of those but couldn't come up with a better place and name

pkg/utils/gateway_wrapper.go

test/policy_integration/dnspolicy_controller_test.go

mikenairn · 2023-11-17T15:23:30Z

/lgtm
/approve

openshift-ci · 2023-11-17T15:23:38Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: makslion, mikenairn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [mikenairn]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci bot added the do-not-merge/work-in-progress label Oct 25, 2023

maksymvavilov had a problem deploying to e2e-internal October 25, 2023 13:24 — with GitHub Actions Failure

maksymvavilov force-pushed the GH-496 branch from 93aca53 to 81fc9fb Compare October 25, 2023 13:27

maksymvavilov had a problem deploying to e2e-internal October 25, 2023 13:27 — with GitHub Actions Failure

maleck13 reviewed Oct 26, 2023

View reviewed changes

pkg/controllers/dnspolicy/dnspolicy_dnsrecords.go Outdated Show resolved Hide resolved

maksymvavilov force-pushed the GH-496 branch from 81fc9fb to 0d87d79 Compare November 2, 2023 10:05

maksymvavilov had a problem deploying to e2e-internal November 2, 2023 10:05 — with GitHub Actions Failure

maksymvavilov force-pushed the GH-496 branch from 0d87d79 to 34d03f0 Compare November 2, 2023 16:05

maksymvavilov temporarily deployed to e2e-internal November 2, 2023 16:05 — with GitHub Actions Inactive

maksymvavilov force-pushed the GH-496 branch from 34d03f0 to a196d09 Compare November 7, 2023 18:20

maksymvavilov had a problem deploying to e2e-internal November 7, 2023 18:20 — with GitHub Actions Failure

maksymvavilov force-pushed the GH-496 branch from a196d09 to d1215f1 Compare November 8, 2023 13:16

maksymvavilov temporarily deployed to e2e-internal November 8, 2023 13:16 — with GitHub Actions Inactive

maksymvavilov force-pushed the GH-496 branch from d1215f1 to 456a9b7 Compare November 9, 2023 10:04

maksymvavilov temporarily deployed to e2e-internal November 9, 2023 10:04 — with GitHub Actions Inactive

mikenairn reviewed Nov 9, 2023

View reviewed changes

pkg/controllers/dnspolicy/dnspolicy_dnsrecords.go Outdated Show resolved Hide resolved

mikenairn reviewed Nov 9, 2023

View reviewed changes

pkg/traffic/gateway.go Outdated Show resolved Hide resolved

mikenairn reviewed Nov 9, 2023

View reviewed changes

pkg/traffic/gateway.go Outdated Show resolved Hide resolved

mikenairn reviewed Nov 9, 2023

View reviewed changes

pkg/traffic/gateway.go Outdated Show resolved Hide resolved

mikenairn reviewed Nov 9, 2023

View reviewed changes

pkg/traffic/gateway.go Outdated Show resolved Hide resolved

maksymvavilov force-pushed the GH-496 branch from 456a9b7 to 1d6e167 Compare November 10, 2023 14:02

maksymvavilov temporarily deployed to e2e-internal November 10, 2023 14:02 — with GitHub Actions Inactive

maksymvavilov force-pushed the GH-496 branch from 1d6e167 to e7deb29 Compare November 10, 2023 14:03

maksymvavilov had a problem deploying to e2e-internal November 10, 2023 14:03 — with GitHub Actions Failure

maksymvavilov changed the title ~~[WIP] GH-496 GW target own cluster~~ GH-496 GW target own cluster Nov 10, 2023

maksymvavilov force-pushed the GH-496 branch from e7deb29 to 19ca30f Compare November 10, 2023 14:13

maksymvavilov marked this pull request as ready for review November 10, 2023 14:13

maksymvavilov had a problem deploying to e2e-internal November 10, 2023 14:13 — with GitHub Actions Failure

openshift-ci bot removed the do-not-merge/work-in-progress label Nov 10, 2023

maksymvavilov force-pushed the GH-496 branch from 19ca30f to 4da904f Compare November 10, 2023 14:15

maksymvavilov force-pushed the GH-496 branch from 5acb068 to f1ed226 Compare November 14, 2023 15:48

maksymvavilov temporarily deployed to e2e-internal November 14, 2023 15:49 — with GitHub Actions Inactive

maksymvavilov force-pushed the GH-496 branch from f1ed226 to e6f428c Compare November 14, 2023 15:49

maksymvavilov temporarily deployed to e2e-internal November 14, 2023 15:49 — with GitHub Actions Inactive